"Looks good. Just a couple of comments -
- LazyData: true
Any particular reason why you're setting this to 'true'? I ask because we've seen this cause problems (long delays) when loading packages with substantial data. My recommendation would be to leave this as 'False'. - Both httr and ggplot2 are imported in DESCRIPTION. They should be selectively or fully imported in the NAMESPACE."
Changing LazyData: false means adding data() functions before each command in examples as mentioned here: http://kbroman.org/pkg_primer/pages/data.html
No good reason not to do this so - DONE.
Using the Roxygen tags to @import ggplot2 and @import httr at the appropriate times changes the NAMESPACE in the appropriate way.
Advice here:
Once, I worked out how to do this - DONE.
So basically all done - testing and version bumping required.
No comments:
Post a Comment